Merge lp://staging/~mikemc/ubuntu-sso-client/fix-1037395-run-mac-tests into lp://staging/ubuntu-sso-client

Proposed by Mike McCracken
Status: Merged
Approved by: dobey
Approved revision: 990
Merged at revision: 1003
Proposed branch: lp://staging/~mikemc/ubuntu-sso-client/fix-1037395-run-mac-tests
Merge into: lp://staging/ubuntu-sso-client
Diff against target: 20 lines (+2/-2)
1 file modified
run-mac-tests (+2/-2)
To merge this branch: bzr merge lp://staging/~mikemc/ubuntu-sso-client/fix-1037395-run-mac-tests
Reviewer Review Type Date Requested Status
dobey (community) Approve
Review via email: mp+119830@code.staging.launchpad.net

Commit message

- Change run-mac-tests script to work with fixed buildout, and use pyflakes (LP: #1037395)

Description of the change

- Change run-mac-tests script to work with fixed buildout, and use pyflakes (LP: #1037395)

To post a comment you must log in.
Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
dobey (dobey) wrote :

If using pyflakes here gives a bunch of warnings/errors, we probably do not want to switch to using it yet on darwin. You should probably not add the USE_PYFLAKES yet.

Revision history for this message
dobey (dobey) :
review: Needs Fixing
Revision history for this message
Mike McCracken (mikemc) wrote :

pylint is also broken on darwin…
I was thinking that if we're going to switch to pyflakes, we might as well start getting the warnings we're planning on fixing now, instead of getting errors we don't intend to fix.

Revision history for this message
dobey (dobey) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches