Midori Web Browser

Merge lp://staging/~midori/midori/innernodeselect into lp://staging/midori

  1. innernodeselect
  2. Merge into trunk
Proposed by Cris Dywan
Status: Work in progress
Proposed branch: lp://staging/~midori/midori/innernodeselect
Merge into: lp://staging/midori
Diff against target: 69 lines (+22/-10)
1 file modified
midori/midori-view.c (+22/-10)
To merge this branch: bzr merge lp://staging/~midori/midori/innernodeselect
Reviewer Review Type Date Requested Status
gue5t gue5t Needs Fixing
Review via email: mp+194033@code.staging.launchpad.net

Commit message

Get selected text for context menu from hit test result

To post a comment you must log in.
lp://staging/~midori/midori/innernodeselect updated
6461. By Cris Dywan

Check for HTML element if it's not a text node

Revision history for this message
gue5t gue5t (gue5t) wrote :

This looks good but it regresses behavior. After this patch, selecting a few letters of a word, right-clicking, and choosing "Search with->Duckduckgo" searches for the entire DOM node's contents instead of just the selected letters. This is not what happens before the patch and not what I would expect to happen as a user.

review: Needs Fixing
Reply
Revision history for this message
Cris Dywan (kalikiana) wrote :

What was lost in IRC conversations is the fact that neither the current trunk nor this branch fully work depending on the website, the original motivation was that it's subjectively broken in trunk.

We need a good idea on how to deal with this. Including how to test it, because opening the next best website is meaningless for this issue.

Reply

Unmerged revisions

6461. By Cris Dywan

Check for HTML element if it's not a text node

6460. By Cris Dywan

Get selected text for context menu from hit test result

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: