Thumbnailer

Merge lp://staging/~michihenning/thumbnailer/s390x-fix into lp://staging/thumbnailer/devel

s390x-fix
Merge into devel

Proposed by Michi Henning on 2015-12-15

Status:	Merged
Approved by:	Michi Henning on 2015-12-21
Approved revision:	320
Merged at revision:	319
Proposed branch:	lp://staging/~michihenning/thumbnailer/s390x-fix
Merge into:	lp://staging/thumbnailer/devel
Diff against target:	25 lines (+7/-1) 1 file modified tests/vs-thumb/vs-thumb_test.cpp (+7/-1)
To merge this branch:	bzr merge lp://staging/~michihenning/thumbnailer/s390x-fix
Related bugs:	Link a bug report

Reviewer	Review Type	Status
Michi Henning (community)		Approve on 2015-12-21
PS Jenkins bot (community)	continuous-integration	Approve on 2015-12-16
Review via email: mp+280653@code.staging.launchpad.net

Commit message

Fixes two minor bugs in the vs-thumb test.

Description of the change

Fixes two minor bugs in the vs-thumb test.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-15:

PASSED: Continuous integration, rev:317
http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-ci/596/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-vivid-amd64-ci/301
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-vivid-armhf-ci/300
        deb: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-vivid-armhf-ci/300/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-vivid-i386-ci/302
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-xenial-amd64-ci/51
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-xenial-armhf-ci/51
        deb: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-xenial-armhf-ci/51/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-xenial-i386-ci/49

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/thumbnailer-devel-ci/596/rebuild

review: Approve (continuous-integration)

lp://staging/~michihenning/thumbnailer/s390x-fix updated on 2015-12-15

318. By Michi Henning on 2015-12-15: Skipping qml test on s390x.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-16:

PASSED: Continuous integration, rev:318
http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-ci/597/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-vivid-amd64-ci/302
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-vivid-armhf-ci/301
        deb: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-vivid-armhf-ci/301/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-vivid-i386-ci/303
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-xenial-amd64-ci/52
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-xenial-armhf-ci/52
        deb: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-xenial-armhf-ci/52/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-xenial-i386-ci/50

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/thumbnailer-devel-ci/597/rebuild

review: Approve (continuous-integration)

lp://staging/~michihenning/thumbnailer/s390x-fix updated on 2015-12-16

319. By Michi Henning on 2015-12-16: Oops, wrong operator.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-12-16:

PASSED: Continuous integration, rev:319
http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-ci/598/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-vivid-amd64-ci/303
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-vivid-armhf-ci/302
        deb: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-vivid-armhf-ci/302/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-vivid-i386-ci/304
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-xenial-amd64-ci/53
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-xenial-armhf-ci/53
        deb: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-xenial-armhf-ci/53/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-xenial-i386-ci/51

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/thumbnailer-devel-ci/598/rebuild

review: Approve (continuous-integration)

Revision history for this message

James Henstridge (jamesh) wrote on 2015-12-16:

Are you sure you want to do this? From the look of it, thumbnailer has never successfully built on s390x (the current version is in dep-wait on missing codec packages).

From Steve's email, we'll be able to publish new packages just fine with broken s390x builds, since they never worked in the first place:

https://lists.launchpad.net/ubuntu-phone/msg17189.html

If you fix the s390x builds, then we're on the hook to keep them working. Further more, by disabling tests like this, it will be harder for other people to tell whether they've got our dependencies working correctly in the future.

lp://staging/~michihenning/thumbnailer/s390x-fix updated on 2015-12-16