Thumbnailer

Merge lp://staging/~michihenning/thumbnailer/fix-warnings into lp://staging/thumbnailer/devel

  1. fix-warnings
  2. Merge into devel
Proposed by Michi Henning
Status: Merged
Approved by: Michi Henning
Approved revision: 366
Merged at revision: 367
Proposed branch: lp://staging/~michihenning/thumbnailer/fix-warnings
Merge into: lp://staging/thumbnailer/devel
Diff against target: 567 lines (+107/-55)
25 files modified
doc/libthumbnailer-qt/examples/qt_example_test.cpp (+4/-0)
include/internal/image.h (+1/-1)
src/image.cpp (+1/-1)
tests/art_extractor/art_extractor_test.cpp (+1/-1)
tests/backoff_adjuster/backoff_adjuster_test.cpp (+1/-1)
tests/check_access/check_access_test.cpp (+1/-1)
tests/dbus/dbus_test.cpp (+5/-5)
tests/download/download_test.cpp (+1/-1)
tests/file_io/file_io_test.cpp (+2/-2)
tests/file_lock/file_lock_test.cpp (+1/-1)
tests/gmock_nowarn.h (+24/-0)
tests/gobj_ptr/gobj_ptr_test.cpp (+9/-9)
tests/gtest_nowarn.h (+24/-0)
tests/image-provider/image-provider_test.cpp (+1/-1)
tests/image/image_test.cpp (+12/-12)
tests/libthumbnailer-qt/libthumbnailer-qt_test.cpp (+1/-1)
tests/recovery/MockCache.h (+1/-1)
tests/safe_strerror/safe_strerror_test.cpp (+1/-1)
tests/settings/settings_test.cpp (+1/-1)
tests/slow-vs-thumb/slow-vs-thumb_test.cpp (+1/-1)
tests/stress/stress_test.cpp (+1/-1)
tests/thumbnailer-admin/thumbnailer-admin_test.cpp (+10/-10)
tests/thumbnailer/thumbnailer_test.cpp (+1/-1)
tests/version/version_test.cpp (+1/-1)
tests/vs-thumb/vs-thumb_test.cpp (+1/-1)
To merge this branch: bzr merge lp://staging/~michihenning/thumbnailer/fix-warnings
Reviewer Review Type Date Requested Status
unity-api-1-bot continuous-integration Approve
James Henstridge Approve
Review via email: mp+314889@code.staging.launchpad.net

Commit message

Fixed a bunch of compiler warnings on zesty.

Description of the change

Fixed a bunch of compiler warnings on zesty.

To post a comment you must log in.
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

PASSED: Continuous integration, rev:366
https://jenkins.canonical.com/unity-api-1/job/lp-thumbnailer-ci/13/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1415
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1422
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1200
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1200/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1200
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1200/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1200
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1200/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1200
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1200/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1200
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1200/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1200
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1200/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-thumbnailer-ci/13/rebuild

review: Approve (continuous-integration)
Revision history for this message
James Henstridge (jamesh) wrote :

Looks good.

review: Approve
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://jenkins.canonical.com/unity-api-1/job/lp-thumbnailer-autoland/120/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1508/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1515
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1293/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1293
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1293/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1293
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1293/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1293
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1293/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1293/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1293
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1293/artifact/output/*zip*/output.zip

review: Needs Fixing (continuous-integration)
Revision history for this message
unity-api-1-bot (unity-api-1-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: