Thumbnailer

Merge lp://staging/~michihenning/thumbnailer/fix-admin-relative-paths into lp://staging/thumbnailer/devel

  1. fix-admin-relative-paths
  2. Merge into devel
Proposed by Michi Henning
Status: Merged
Approved by: James Henstridge
Approved revision: 343
Merged at revision: 342
Proposed branch: lp://staging/~michihenning/thumbnailer/fix-admin-relative-paths
Merge into: lp://staging/thumbnailer/devel
Diff against target: 137 lines (+42/-11)
5 files modified
src/libthumbnailer-qt/libthumbnailer-qt.cpp (+12/-1)
src/thumbnailer-admin/thumbnailer-admin.cpp (+0/-2)
src/thumbnailer.cpp (+5/-0)
tests/thumbnailer-admin/thumbnailer-admin_test.cpp (+3/-7)
tests/thumbnailer/thumbnailer_test.cpp (+22/-1)
To merge this branch: bzr merge lp://staging/~michihenning/thumbnailer/fix-admin-relative-paths
Reviewer Review Type Date Requested Status
James Henstridge Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+284192@code.staging.launchpad.net

Commit message

Canonicalise paths on the client side because relative paths on the server side don't make sense.

Description of the change

Canonicalise paths on the client side because relative paths on the server side don't make sense.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:342
http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-ci/648/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-vivid-amd64-ci/352
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-vivid-armhf-ci/353
        deb: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-vivid-armhf-ci/353/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-vivid-i386-ci/353
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-xenial-amd64-ci/102
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-xenial-armhf-ci/103
        deb: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-xenial-armhf-ci/103/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/thumbnailer-devel-xenial-i386-ci/100

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/thumbnailer-devel-ci/648/rebuild

review: Approve (continuous-integration)
Revision history for this message
James Henstridge (jamesh) wrote :

Looks like a good change. But can we get rid of the multiple canonical() calls on the client side?

lp://staging/~michihenning/thumbnailer/fix-admin-relative-paths updated
343. By Michi Henning

Review comments from James.

Revision history for this message
James Henstridge (jamesh) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: