Merge lp://staging/~michihenning/thumbnailer/animated-gifs into lp://staging/thumbnailer/devel

Proposed by Michi Henning
Status: Merged
Approved by: Michi Henning
Approved revision: 335
Merged at revision: 333
Proposed branch: lp://staging/~michihenning/thumbnailer/animated-gifs
Merge into: lp://staging/thumbnailer/devel
Diff against target: 117 lines (+45/-0)
3 files modified
debian/changelog (+2/-0)
src/thumbnailer.cpp (+24/-0)
tests/thumbnailer/thumbnailer_test.cpp (+19/-0)
To merge this branch: bzr merge lp://staging/~michihenning/thumbnailer/animated-gifs
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Michi Henning (community) Approve
Review via email: mp+281975@code.staging.launchpad.net

Commit message

Limit extraction of thumbnails from GIF to files no larger than 2 MB.

Description of the change

Limit extraction of thumbnails from GIF to files no larger than 2 MB. That's the most sensible thing to do, considering the insane amount of effort it would have taken to deal with animated GIFs without consuming lots of memory. Reasonable non-animated GIFs and small animated ones will still thumbnail correctly.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
335. By Michi Henning

Better log message.

Revision history for this message
Michi Henning (michihenning) wrote :

Top-approving after testing on Mako.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: