Merge lp://staging/~michihenning/thumbnailer/animated-gifs into lp://staging/thumbnailer/devel
Proposed by
Michi Henning
Status: | Merged |
---|---|
Approved by: | Michi Henning |
Approved revision: | 335 |
Merged at revision: | 333 |
Proposed branch: | lp://staging/~michihenning/thumbnailer/animated-gifs |
Merge into: | lp://staging/thumbnailer/devel |
Diff against target: |
117 lines (+45/-0) 3 files modified
debian/changelog (+2/-0) src/thumbnailer.cpp (+24/-0) tests/thumbnailer/thumbnailer_test.cpp (+19/-0) |
To merge this branch: | bzr merge lp://staging/~michihenning/thumbnailer/animated-gifs |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Michi Henning (community) | Approve | ||
Review via email: mp+281975@code.staging.launchpad.net |
Commit message
Limit extraction of thumbnails from GIF to files no larger than 2 MB.
Description of the change
Limit extraction of thumbnails from GIF to files no larger than 2 MB. That's the most sensible thing to do, considering the insane amount of effort it would have taken to deal with animated GIFs without consuming lots of memory. Reasonable non-animated GIFs and small animated ones will still thumbnail correctly.
To post a comment you must log in.
PASSED: Continuous integration, rev:334 jenkins. qa.ubuntu. com/job/ thumbnailer- devel-ci/ 628/ jenkins. qa.ubuntu. com/job/ thumbnailer- devel-vivid- amd64-ci/ 332 jenkins. qa.ubuntu. com/job/ thumbnailer- devel-vivid- armhf-ci/ 333 jenkins. qa.ubuntu. com/job/ thumbnailer- devel-vivid- armhf-ci/ 333/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ thumbnailer- devel-vivid- i386-ci/ 333 jenkins. qa.ubuntu. com/job/ thumbnailer- devel-xenial- amd64-ci/ 82 jenkins. qa.ubuntu. com/job/ thumbnailer- devel-xenial- armhf-ci/ 83 jenkins. qa.ubuntu. com/job/ thumbnailer- devel-xenial- armhf-ci/ 83/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ thumbnailer- devel-xenial- i386-ci/ 80
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/thumbnailer -devel- ci/628/ rebuild
http://