persistent-cache-cpp

Merge lp://staging/~michihenning/persistent-cache-cpp/fix-move-construct into lp://staging/persistent-cache-cpp/devel

  1. fix-move-construct
  2. Merge into devel
Proposed by Michi Henning
Status: Merged
Approved by: James Henstridge
Approved revision: 41
Merged at revision: 39
Proposed branch: lp://staging/~michihenning/persistent-cache-cpp/fix-move-construct
Merge into: lp://staging/persistent-cache-cpp/devel
Prerequisite: lp://staging/~michihenning/persistent-cache-cpp/fix-copyright-xenial
Diff against target: 83 lines (+37/-6)
4 files modified
debian/changelog (+7/-0)
include/core/persistent_cache_stats.h (+1/-1)
src/core/persistent_cache_stats.cpp (+9/-5)
tests/core/persistent_string_cache/persistent_string_cache_test.cpp (+20/-0)
To merge this branch: bzr merge lp://staging/~michihenning/persistent-cache-cpp/fix-move-construct
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
James Henstridge Approve
Unity API Team Pending
Review via email: mp+280105@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-12-09.

Commit message

Fixed assertion failure when move-constructing from internal stats instance.

Description of the change

Fixed assertion failure when move-constructing from internal stats instance.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:39
http://jenkins.qa.ubuntu.com/job/persistent-cache-cpp-devel-ci/25/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/persistent-cache-cpp-devel-wily-amd64-ci/25
    SUCCESS: http://jenkins.qa.ubuntu.com/job/persistent-cache-cpp-devel-wily-armhf-ci/25
        deb: http://jenkins.qa.ubuntu.com/job/persistent-cache-cpp-devel-wily-armhf-ci/25/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/persistent-cache-cpp-devel-wily-i386-ci/25

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/persistent-cache-cpp-devel-ci/25/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:40
http://jenkins.qa.ubuntu.com/job/persistent-cache-cpp-devel-ci/26/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/persistent-cache-cpp-devel-wily-amd64-ci/26
    SUCCESS: http://jenkins.qa.ubuntu.com/job/persistent-cache-cpp-devel-wily-armhf-ci/26
        deb: http://jenkins.qa.ubuntu.com/job/persistent-cache-cpp-devel-wily-armhf-ci/26/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/persistent-cache-cpp-devel-wily-i386-ci/26

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/persistent-cache-cpp-devel-ci/26/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:40
http://jenkins.qa.ubuntu.com/job/persistent-cache-cpp-devel-ci/29/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/persistent-cache-cpp-devel-xenial-amd64-ci/3
    FAILURE: http://jenkins.qa.ubuntu.com/job/persistent-cache-cpp-devel-xenial-armhf-ci/3/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/persistent-cache-cpp-devel-xenial-i386-ci/3/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/persistent-cache-cpp-devel-ci/29/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~michihenning/persistent-cache-cpp/fix-move-construct updated
41. By Michi Henning

Merged dependent branch.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:41
http://jenkins.qa.ubuntu.com/job/persistent-cache-cpp-devel-ci/30/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/persistent-cache-cpp-devel-xenial-amd64-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/persistent-cache-cpp-devel-xenial-armhf-ci/4
        deb: http://jenkins.qa.ubuntu.com/job/persistent-cache-cpp-devel-xenial-armhf-ci/4/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/persistent-cache-cpp-devel-xenial-i386-ci/4

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/persistent-cache-cpp-devel-ci/30/rebuild

review: Approve (continuous-integration)
Revision history for this message
James Henstridge (jamesh) wrote :

Looks good.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: