Code review comment for ~michal-maloszewski99/ubuntu/+source/apache2:passing-health-check-lp2003189-kinetic

Sure, Bryce, I will explain.

11320 # Test 2 got: "126" (t/apache/mmn.t at line 42)
11321 #   Expected: "125"
11322 t/apache/mmn.t ......................·

It is a snippet of the log, I saw it, and there it came to my mind that there is a problem with that "magic number".
Btw, it was not only a comment that was changed.

Let me copy some part of the code from the Preview Diff from 3rd of May:

1. +  * 20120211.124 (2.4.51-dev) Add name_ex to struct proxy_worker_shared
2. +- *
3. ++ * 20120211.125 (2.4.55-dev) Add additional hcmethod_t enums and
                          PROXY_WORKER_IS_ERROR
4.
5. +  */
6. +
7. + #define MODULE_MAGIC_COOKIE 0x41503234UL /* "AP24" */
8. +@@ -600,7 +601,7 @@
9. + #ifndef MODULE_MAGIC_NUMBER_MAJOR
10. + #define MODULE_MAGIC_NUMBER_MAJOR 20120211
11. + #endif
12. +-#define MODULE_MAGIC_NUMBER_MINOR 124                 /* 0...n */
13. ++#define MODULE_MAGIC_NUMBER_MINOR 126                 /* 0...n */

Line number 3: * 20120211.125 (2.4.55-dev) Add additional hcmethod_t enums and
                          PROXY_WORKER_IS_ERROR
Line number 13: #define MODULE_MAGIC_NUMBER_MINOR 126                 /* 0...n */

There was a discrepancy in terms of incrementation -> 125!=126
That was an easy mistake that was not spotted.

Why did it not fail on Jammy?

1. +- *
2. ++ * 20120211.126 (2.4.55-dev) Add additional hcmethod_t enums and
3. ++                             PROXY_WORKER_IS_ERROR
4. +  */
5. +
6. + #define MODULE_MAGIC_COOKIE 0x41503234UL /* "AP24" */
7. +@@ -595,7 +596,7 @@
8. + #ifndef MODULE_MAGIC_NUMBER_MAJOR
9. + #define MODULE_MAGIC_NUMBER_MAJOR 20120211
10. + #endif
11. +-#define MODULE_MAGIC_NUMBER_MINOR 121                 /* 0...n */
12. ++#define MODULE_MAGIC_NUMBER_MINOR 126                 /* 0...n */

There we have:

Line 2  - 126
Line 12 - 126

126=126