Merge lp://staging/~michael.nelson/ubuntu-webcatalog/987838-no-screenshot-for-extras into lp://staging/ubuntu-webcatalog

Proposed by Michael Nelson
Status: Merged
Approved by: Łukasz Czyżykowski
Approved revision: 120
Merged at revision: 118
Proposed branch: lp://staging/~michael.nelson/ubuntu-webcatalog/987838-no-screenshot-for-extras
Merge into: lp://staging/ubuntu-webcatalog
Diff against target: 38 lines (+15/-2)
2 files modified
src/webcatalog/tests/test_views.py (+14/-0)
src/webcatalog/views.py (+1/-2)
To merge this branch: bzr merge lp://staging/~michael.nelson/ubuntu-webcatalog/987838-no-screenshot-for-extras
Reviewer Review Type Date Requested Status
Łukasz Czyżykowski (community) Approve
Review via email: mp+104876@code.staging.launchpad.net

Commit message

application_screenshots no longer dependent on redundant data (is_latest).

Description of the change

Ensures that the application_screenshots view is not dependent on redundant data (is_latest).

Another part of the fix for this should be ensuring that the check_all_latest command is run after each import (import_app_install_data and import_for_purchase), but I want to check with achuni about that first as it looks like the kind of command we wouldn't want to run unnecessarily (ie. after each import of a distroseries, but rather after importing all distroseries - which may be why it's been left manual).

`fab test`

To post a comment you must log in.
Revision history for this message
Łukasz Czyżykowski (lukasz-czyzykowski) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches