Merge lp://staging/~michael.nelson/ubuntu-webcatalog/1039073-click-url-should-open-in-own-window into lp://staging/ubuntu-webcatalog
Proposed by
Michael Nelson
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Łukasz Czyżykowski | ||||
| Approved revision: | 165 | ||||
| Merged at revision: | 164 | ||||
| Proposed branch: | lp://staging/~michael.nelson/ubuntu-webcatalog/1039073-click-url-should-open-in-own-window | ||||
| Merge into: | lp://staging/ubuntu-webcatalog | ||||
| Diff against target: |
12 lines (+1/-1) 1 file modified
src/webcatalog/templates/webcatalog/exhibits_widget.html (+1/-1) |
||||
| To merge this branch: | bzr merge lp://staging/~michael.nelson/ubuntu-webcatalog/1039073-click-url-should-open-in-own-window | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Łukasz Czyżykowski (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Tiny change so that clicks on an exhibit open the url in a new tab.
At first I was unsure if we should do this for all exhibits, or just those with click_url's (ie. external), but it seemed inconsistent to do it only for some exhibits. That said, if it's related to the external/internal link, maybe it would be better only do on external? Let me know.
I'm personally -1 to opening in a new tab/window - I don't really see the benefit in our use-case.
To post a comment you must log in.
Revision history for this message
| Łukasz Czyżykowski (lukasz-czyzykowski) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
