Merge lp://staging/~michael.nelson/rnr-server/framework-as-distroseries-for-click into lp://staging/rnr-server
Proposed by
Michael Nelson
| Status: | Merged |
|---|---|
| Approved by: | Michael Nelson |
| Approved revision: | 247 |
| Merged at revision: | 242 |
| Proposed branch: | lp://staging/~michael.nelson/rnr-server/framework-as-distroseries-for-click |
| Merge into: | lp://staging/rnr-server |
| Diff against target: |
190 lines (+85/-13) 5 files modified
src/reviewsapp/api/urls.py (+3/-3) src/reviewsapp/forms.py (+17/-3) src/reviewsapp/tests/test_handlers.py (+47/-0) src/reviewsapp/tests/test_utilities.py (+12/-6) src/reviewsapp/utilities.py (+6/-1) |
| To merge this branch: | bzr merge lp://staging/~michael.nelson/rnr-server/framework-as-distroseries-for-click |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Nelson (community) | Approve | ||
| dobey (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Click reviews use framework as distroseries and packagename as origin.
Description of the change
As per discussions on the client MP [1], this branch updates the review server so that:
1) It expects the framework to be passed as the distroseries when creating or filtering click reviews
2) It enforces that origin==packagename for click package reviews (the other option would be to not validate the origin for click packages, but that'd lead to inconsistencies when filtering for different packages)
[1] https:/
To post a comment you must log in.
Revision history for this message
| dobey (dobey) | # |
review:
Approve
Revision history for this message
| Michael Nelson (michael.nelson) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
