Merge lp://staging/~michael.nelson/rnr-server/dont-depend-on-appname-2 into lp://staging/rnr-server
Proposed by
Michael Nelson
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Michael Nelson | ||||
| Approved revision: | 175 | ||||
| Merged at revision: | 163 | ||||
| Proposed branch: | lp://staging/~michael.nelson/rnr-server/dont-depend-on-appname-2 | ||||
| Merge into: | lp://staging/rnr-server | ||||
| Prerequisite: | lp://staging/~michael.nelson/rnr-server/dont-depend-on-appname | ||||
| Diff against target: |
441 lines (+192/-36) 10 files modified
src/reviewsapp/api/handlers.py (+6/-2) src/reviewsapp/forms.py (+1/-2) src/reviewsapp/management/commands/populate.py (+2/-2) src/reviewsapp/migrations/0008_remove_softwareitem_app_name.py (+159/-0) src/reviewsapp/models/reviews.py (+1/-6) src/reviewsapp/tests/factory.py (+2/-2) src/reviewsapp/tests/matchers.py (+5/-4) src/reviewsapp/tests/test_handlers.py (+8/-8) src/reviewsapp/tests/test_rnrclient.py (+6/-7) src/reviewsapp/utilities.py (+2/-3) |
||||
| To merge this branch: | bzr merge lp://staging/~michael.nelson/rnr-server/dont-depend-on-appname-2 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Anthony Lenton (community) | Approve | ||
|
Review via email:
|
|||
Commit message
[r=achuni][bug=737649] Remove SoftwareItem.
Description of the change
Overview
========
This branch follows on from the pre-requisite, and simply removes the SoftwareItem.
This branch changes the API only in that the review statistics 'app_name' attribute is always empty.
I'll do a last branch separately which will also update the get_reviews API call to ignore the requested app name, returning all reviews for the package, so that mvo/achuni can decide which changes they want landed.
To post a comment you must log in.
Revision history for this message
| Anthony Lenton (elachuni) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
