Ratings and Reviews server

Merge lp://staging/~michael.nelson/rnr-server/1262627-verify-click into lp://staging/rnr-server

  1. 1262627-verify-click
  2. Merge into trunk
Proposed by Michael Nelson
Status: Merged
Merged at revision: 235
Proposed branch: lp://staging/~michael.nelson/rnr-server/1262627-verify-click
Merge into: lp://staging/rnr-server
Diff against target: 246 lines (+99/-17)
6 files modified
src/reviewsapp/forms.py (+2/-2)
src/reviewsapp/schema.py (+4/-0)
src/reviewsapp/tests/test_handlers.py (+1/-1)
src/reviewsapp/tests/test_rnrclient.py (+3/-3)
src/reviewsapp/tests/test_utilities.py (+73/-9)
src/reviewsapp/utilities.py (+16/-2)
To merge this branch: bzr merge lp://staging/~michael.nelson/rnr-server/1262627-verify-click
Reviewer Review Type Date Requested Status
James Tait (community) Approve
Michael Nelson (community) Approve
Review via email: mp+199816@code.staging.launchpad.net

Commit message

Check a packagename using the click-package-index.

Description of the change

Fix for bug 1262627 - when origin-distroseries is ubuntu-click, check for a valid package using the click-package-index api.

To post a comment you must log in.
Revision history for this message
Michael Nelson (michael.nelson) wrote :

self-approving so I can go ahead with getting this on staging, but happy to do a second branch with any review changes.

review: Approve
Revision history for this message
James Tait (jamestait) wrote :

I'm not familiar with the code, but this seems self-explanatory and looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches