Launchpad itself

lib/lp/registry/configure.zcml (+12/-0)
lib/lp/registry/interfaces/distroseriesdifference.py (+8/-1)
lib/lp/registry/interfaces/distroseriesdifferencecomment.py (+57/-0)
lib/lp/registry/model/distroseriesdifference.py (+22/-1)
lib/lp/registry/model/distroseriesdifferencecomment.py (+67/-0)
lib/lp/registry/tests/test_distroseriesdifference.py (+29/-2)
lib/lp/registry/tests/test_distroseriesdifferencecomment.py (+44/-0)
lib/lp/testing/factory.py (+16/-0)

To merge this branch:

bzr merge lp://staging/~michael.nelson/launchpad/distro-series-difference-message

Medium

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Brad Crittenden (community)	code	2010-08-27	Approve on 2010-08-27
Launchpad code reviewers		2010-08-27	Pending
Review via email: mp+33929@code.staging.launchpad.net

Commit message

Add DistroSeriesDifferenceComment model.

Description of the change

Overview
========
Hi Brad or other reviewer :)

This branch adds the comment model for DistroSeriesDifferences, and then adds a IDistroSeriesDifference.addComment().

This is part of the work for:

https://dev.launchpad.net/LEP/DerivativeDistributions

To test:
bin/test -vv -m lp.registry.tests.test_distroseriesdifferencecomment -m lp.registry.tests.test_distroseriesdifference

No lint.

Revision history for this message

Brad Crittenden (bac) wrote on 2010-08-27:

Hi Michael,

Thanks for this addition.

I think this would read better if the actual were on a line by itself.

279 + self.assertEqual(
280 + "Difference between distroseries 'Lucid' and 'Derilucid' "
281 + "for package 'foonew' (1.0/0.9)", ds_diff.title)

Otherwise it looks great.

review: Approve (code)

Revision history for this message

Michael Nelson (michael.nelson) wrote on 2010-08-30:

On Fri, Aug 27, 2010 at 7:31 PM, Brad Crittenden <email address hidden> wrote:
> Review: Approve code
> Hi Michael,
>
> Thanks for this addition.
>
> I think this would read better if the actual were on a line by itself.
>
> 279 + self.assertEqual(
> 280 + "Difference between distroseries 'Lucid' and 'Derilucid' "
> 281 + "for package 'foonew' (1.0/0.9)", ds_diff.title)

Done, thanks Brad.

>
> Otherwise it looks great.