Merge lp://staging/~michael.nelson/launchpad/db-changes-build-generalisation-new into lp://staging/launchpad/db-devel
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 9405 | ||||
Proposed branch: | lp://staging/~michael.nelson/launchpad/db-changes-build-generalisation-new | ||||
Merge into: | lp://staging/launchpad/db-devel | ||||
Diff against target: |
736 lines (+484/-113) 5 files modified
database/sampledata/current-dev.sql (+112/-44) database/sampledata/current.sql (+112/-44) database/schema/comments.sql (+26/-17) database/schema/patch-2207-57-0.sql (+210/-0) database/schema/security.cfg (+24/-8) |
||||
To merge this branch: | bzr merge lp://staging/~michael.nelson/launchpad/db-changes-build-generalisation-new | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Björn Tillenius (community) | db | Approve | |
Stuart Bishop (community) | db | Approve | |
Review via email: mp+25594@code.staging.launchpad.net |
Description of the change
This branch is the schema change required for:
https:/
https:/
A slightly out-of-date visual for the schema change can be seen here:
http://
Overview
========
This schema change splits the current Build table into three: BuildFarmJob, PackageBuild and BinaryPackageBuild, and then migrates the data across. It also updates foreign key references, and some old views that are still used by the codebase to use the new tables.
I did chat with stub about this and he said with only a few hundred thousand records, performance isn't an issue, but it would be good to get him to confirm that after reading through the patch (we'll also test it on dogfood).
There is a pipeline of over 7k lines of code changes that need to land with this that ensures all the tests pass. It's all approved, currently ending with:
I just need to merge those changes with a fresh db-devel and resolve conflicts, before getting this on dogfood for some serious testing.
Hi stub or BjornT:
When I ran this schema change (together with the code changes) through ec2 test, I see the following error in test_sampledata - it seems related to moving the old build table to the todrop namespace rather than deleting it leaves the constraints in place - I assume I just remove the constraints on todrop.build?
http:// pastebin. ubuntu. com/436693/
Also, there are a bunch of other failures:
http:// pastebin. ubuntu. com/436699/
which are (I assume) because listReferences( cursor( ), 'libraryfilealias', 'id') still returns 'build' as a from table? pastebin. ubuntu. com/436710/
http://