Merge lp://staging/~michael.nelson/launchpad/589058-upload-rejected-date-started-not-set into lp://staging/launchpad
Proposed by
Michael Nelson
| Status: | Merged |
|---|---|
| Approved by: | Edwin Grubbs |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 10981 |
| Proposed branch: | lp://staging/~michael.nelson/launchpad/589058-upload-rejected-date-started-not-set |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
71 lines (+36/-5) 2 files modified
lib/lp/soyuz/model/binarypackagebuild.py (+6/-5) lib/lp/soyuz/tests/test_binarypackagebuild.py (+30/-0) |
| To merge this branch: | bzr merge lp://staging/~michael.nelson/launchpad/589058-upload-rejected-date-started-not-set |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Edwin Grubbs (community) | code | Approve | |
|
Review via email:
|
|||
Description of the change
This fixes bug 589068 (despite the branch name) by ensuring that, when estimating the duration of a build, the previous build is only used if it has both date_started and date_finished.
See the bug for why there are completed builds without date_started (rollout related). This branch just makes sure we don't fall over when this occurs.
to test:
bin/test -vvm test_binarypack
No lint (although strange exceptions while running `make lint`.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good.