Merge lp://staging/~michael.nelson/launchpad/567922-binarypackagebuild-packagebuild into lp://staging/launchpad/db-devel

Proposed by Michael Nelson
Status: Merged
Approved by: Eleanor Berger
Approved revision: no longer in the source branch.
Merged at revision: 9405
Proposed branch: lp://staging/~michael.nelson/launchpad/567922-binarypackagebuild-packagebuild
Merge into: lp://staging/launchpad/db-devel
Prerequisite: lp://staging/~michael.nelson/launchpad/db-package-build-model
Diff against target: 563 lines (+261/-40)
11 files modified
lib/canonical/launchpad/interfaces/_schema_circular_imports.py (+2/-0)
lib/lp/buildmaster/browser/configure.zcml (+14/-0)
lib/lp/buildmaster/browser/packagebuild.py (+42/-0)
lib/lp/buildmaster/configure.zcml (+1/-1)
lib/lp/buildmaster/interfaces/buildbase.py (+3/-0)
lib/lp/buildmaster/interfaces/buildfarmjob.py (+50/-20)
lib/lp/buildmaster/interfaces/packagebuild.py (+31/-6)
lib/lp/buildmaster/model/buildfarmjob.py (+30/-0)
lib/lp/buildmaster/model/packagebuild.py (+27/-0)
lib/lp/buildmaster/tests/test_buildfarmjob.py (+11/-0)
lib/lp/buildmaster/tests/test_packagebuild.py (+50/-13)
To merge this branch: bzr merge lp://staging/~michael.nelson/launchpad/567922-binarypackagebuild-packagebuild
Reviewer Review Type Date Requested Status
Eleanor Berger (community) code Approve
Review via email: mp+24107@code.staging.launchpad.net

Description of the change

This branch is part of a pipeline for

https://blueprints.edge.launchpad.net/soyuz/+spec/build-generalisation
https://dev.launchpad.net/LEP/GeneralBuildHistories

In particular, this branch updates the IBuildFarmJob/IPackageJob interfaces and implementations so that items currently exported on IBinaryPackageBuild will continue to be exported when (in the next branch) the implementation of IBinaryPackageBuild switches to use the new tables.

It is dependent on the pending schema patch in a previous branch.

To test
=======

First update the test db schema (required as the db patch still needs to be updated to remove the old build table):
psql launchpad_ftest_template -f database/schema/pending/michaeln-build-generalisation.sql
bin/py database/schema/security.py -d launchpad_ftest_template

And then:
bin/test -vvt test_packagebuild -t test_buildfarmjob -t doc/build.txt -t test_buildqueue -t test_sourcepackagerecipebuild -t test_buildpackagejob

The next stage will be to add the methods currently defined for IBinaryPackageBuild to IBuildFarmJob/IPackageJob before switching the BinaryPackageBuild from the old build table to the new binarypackagebuild table.

To post a comment you must log in.
Revision history for this message
Eleanor Berger (intellectronica) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: