Merge lp://staging/~michael.nelson/launchpad/550049-overwriting-buildd-manager-files-2 into lp://staging/launchpad

Proposed by Michael Nelson
Status: Merged
Approved by: Michael Nelson
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp://staging/~michael.nelson/launchpad/550049-overwriting-buildd-manager-files-2
Merge into: lp://staging/launchpad
Diff against target: 239 lines (+121/-31)
3 files modified
lib/lp/buildmaster/model/buildbase.py (+38/-23)
lib/lp/buildmaster/tests/test_buildbase.py (+74/-4)
lib/lp/soyuz/tests/soyuzbuilddhelpers.py (+9/-4)
To merge this branch: bzr merge lp://staging/~michael.nelson/launchpad/550049-overwriting-buildd-manager-files-2
Reviewer Review Type Date Requested Status
Michael Nelson (community) code Approve
Julian Edwards (community) Approve
Review via email: mp+23398@code.staging.launchpad.net

Commit message

Adds basic test for buildStatus_OK, ensuring that paths outside the upload dir are not written.

Description of the change

This branch is just a merge of a fix that is already on production.

That (private) MP can be seen at:
https://code.edge.launchpad.net/~michael.nelson/launchpad/pd-550049-overwriting-buildd-manager-files/+merge/22932

To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) wrote :

rs=me, this is already landed in production

review: Approve
Revision history for this message
Michael Nelson (michael.nelson) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.