Merge lp://staging/~michael.nelson/launchpad/536700-present-packagebuilds-in-ppa-context-2 into lp://staging/launchpad
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Graham Binns | ||||
| Approved revision: | no longer in the source branch. | ||||
| Merged at revision: | 11041 | ||||
| Proposed branch: | lp://staging/~michael.nelson/launchpad/536700-present-packagebuilds-in-ppa-context-2 | ||||
| Merge into: | lp://staging/launchpad | ||||
| Prerequisite: | lp://staging/~michael.nelson/launchpad/536700-present-packagebuilds-in-ppa-context | ||||
| Diff against target: |
372 lines (+120/-31) 11 files modified
lib/lp/buildmaster/interfaces/buildfarmjob.py (+28/-0) lib/lp/buildmaster/model/builder.py (+1/-1) lib/lp/buildmaster/model/buildfarmjob.py (+38/-2) lib/lp/buildmaster/tests/test_buildfarmjob.py (+16/-1) lib/lp/registry/model/distroseries.py (+2/-2) lib/lp/soyuz/browser/archive.py (+4/-0) lib/lp/soyuz/browser/build.py (+10/-3) lib/lp/soyuz/configure.zcml (+2/-1) lib/lp/soyuz/interfaces/binarypackagebuild.py (+0/-1) lib/lp/soyuz/model/binarypackagebuild.py (+10/-7) lib/lp/soyuz/tests/test_binarypackagebuild.py (+9/-13) |
||||
| To merge this branch: | bzr merge lp://staging/~michael.nelson/launchpad/536700-present-packagebuilds-in-ppa-context-2 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Graham Binns (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
List of builds presented in a PPA context includes all package builds rather than only binary package builds.
Description of the change
Please review my branch:
bzr+
revision 11014.
Demo URL:
https:/
(ie. it still works, with no visible changes).
Test command:
bin/test -vvm test_buildfarmjob -m test_binarypack
Pre-implementation call with: I chatted with Gary about the nested proxy
which is explained in getSpecificJob().
This branch updates the PPA builds view so that it operates on more general
IPackageBuilds rather than IBinaryPackageB
will also be displayed here).
It does so by adding a getSpecificJob() method to IBuildFarmJob which returns
the related specific job (in this case, the BinaryPackageBu
browser view now finds a batch of IPackageBuild items, and then gets the
specific job for each item to display.
was_built from IBinaryPackageBuild to IBuildFarmJob (so it is available in the
template regardless of the build farm job type).
| Graham Binns (gmb) | # |
