Merge lp://staging/~michael.nelson/django-openid-auth/701489-rename-signal-provide-openid-response into lp://staging/~django-openid-auth/django-openid-auth/trunk

Proposed by Michael Nelson
Status: Merged
Merged at revision: 79
Proposed branch: lp://staging/~michael.nelson/django-openid-auth/701489-rename-signal-provide-openid-response
Merge into: lp://staging/~django-openid-auth/django-openid-auth/trunk
Diff against target: 81 lines (+13/-13)
3 files modified
django_openid_auth/signals.py (+2/-2)
django_openid_auth/tests/test_views.py (+8/-6)
django_openid_auth/views.py (+3/-5)
To merge this branch: bzr merge lp://staging/~michael.nelson/django-openid-auth/701489-rename-signal-provide-openid-response
Reviewer Review Type Date Requested Status
Anthony Lenton Approve
Review via email: mp+46105@code.staging.launchpad.net

Description of the change

Overview
========

This branch fixes two issues that landed with my previous branch (r78), renaming the signal from oauth_login_complete -> openid_login_complete, and updating the signal to pass the openid_response instead of the sreg_response kwarg (more general and useful).

To test: `make check`

To post a comment you must log in.
Revision history for this message
Anthony Lenton (elachuni) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches