Merge lp://staging/~michael.nelson/charms/trusty/squid-reverseproxy/1454485-set-visible-hostname into lp://staging/charms/trusty/squid-reverseproxy
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 55 | ||||
| Proposed branch: | lp://staging/~michael.nelson/charms/trusty/squid-reverseproxy/1454485-set-visible-hostname | ||||
| Merge into: | lp://staging/charms/trusty/squid-reverseproxy | ||||
| Diff against target: |
20 lines (+2/-0) 2 files modified
hooks/hooks.py (+1/-0) templates/main_config.template (+1/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~michael.nelson/charms/trusty/squid-reverseproxy/1454485-set-visible-hostname | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tim Van Steenburgh (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Add visible_hostname to avoid excessive DNS queries (bug 1454485)
Description of the change
See bug 1454485 for the details.
Tested locally with a (private) deployment upgrade at:
https:/
Before upgrade:
dev-trusty# ~/charms/
$ juju run --service sca-cache "head /etc/squid3/
http_port 3128 accel vhost
acl PURGE method PURGE
acl CONNECT method CONNECT
...
After upgrade:
dev-trusty# ~/charms/
$ juju run --service sca-cache "head /etc/squid3/
visible_hostname michael-
http_port 3128 accel vhost
acl PURGE method PURGE
acl CONNECT method CONNECT
...
Locally I don't have any rDNS issues, but I've manually checked on our staging env to verify that adding the generated visible_hostname does stop the log messages (and from the squid code, the excessive DNS queries).
+1, LGTM, thanks Michael!