webapps-demo

Merge lp://staging/~michael-sheldon/webapps-demo/twitter-location into lp://staging/webapps-demo

  1. twitter-location
  2. Merge into trunk
Proposed by Michael Sheldon
Status: Needs review
Proposed branch: lp://staging/~michael-sheldon/webapps-demo/twitter-location
Merge into: lp://staging/webapps-demo
Diff against target: 25 lines (+3/-2)
2 files modified
webapp-twitter/manifest.json (+1/-1)
webapp-twitter/webapp-twitter.json (+2/-1)
To merge this branch: bzr merge lp://staging/~michael-sheldon/webapps-demo/twitter-location
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
David Barth Pending
Ubuntu Phablet Team Pending
Review via email: mp+206973@code.staging.launchpad.net

Commit message

Add permission for location detection

Description of the change

This adds the "location" policy group to the twitter app and bumps the version number, fixing bug #1281631 (twitter app crashes when accessing location).

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:35
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~michael-sheldon/webapps-demo/twitter-location/+merge/206973/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/webapps-demo-ci/38/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webapps-demo-saucy-armhf-ci/21
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webapps-demo-saucy-i386-ci/21

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webapps-demo-ci/38/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:35
http://jenkins.qa.ubuntu.com/job/webapps-demo-ci/40/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webapps-demo-saucy-armhf-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webapps-demo-saucy-i386-ci/23

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webapps-demo-ci/40/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?

 * No test plan, performed manual tests of basic functionality.

If you changed the UI, was the change specified/approved by design?

 * No change

If you changed the packaging (debian), did you subscribe a core-dev to this MP?

 * No change

Reply

Unmerged revisions

35. By Michael Sheldon

Add location policy group to twitter app (fixes crash when tweeting with location detection allowed)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches