webapps-demo

Merge lp://staging/~michael-sheldon/webapps-demo/fileupload into lp://staging/webapps-demo

  1. fileupload
  2. Merge into trunk
Proposed by Michael Sheldon
Status: Needs review
Proposed branch: lp://staging/~michael-sheldon/webapps-demo/fileupload
Merge into: lp://staging/webapps-demo
Diff against target: 77 lines (+9/-6)
6 files modified
webapp-facebook/manifest.json (+1/-1)
webapp-facebook/webapp-facebook.json (+2/-1)
webapp-gmail/manifest.json (+1/-1)
webapp-gmail/webapp-gmail.json (+2/-1)
webapp-ubuntuone/manifest.json (+1/-1)
webapp-ubuntuone/webapp-ubuntuone.json (+2/-1)
To merge this branch: bzr merge lp://staging/~michael-sheldon/webapps-demo/fileupload
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
David Barth Pending
Ubuntu Phablet Team Pending
Review via email: mp+206976@code.staging.launchpad.net

Commit message

add permissions for file upload

Description of the change

This branch adds the "content_exchange" policy group to the GMail, Facebook and Ubuntu One apps. This is in preparation for upload support arriving in the browser, which is based around Content Hub imports. I wasn't able to find upload facilities in any of the other apps, so I've left those with their original policy groups for now (but this may need changing in the future if the apps add these facilities).

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:36
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~michael-sheldon/webapps-demo/fileupload/+merge/206976/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/webapps-demo-ci/37/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webapps-demo-saucy-armhf-ci/20
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webapps-demo-saucy-i386-ci/20

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webapps-demo-ci/37/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:36
http://jenkins.qa.ubuntu.com/job/webapps-demo-ci/39/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webapps-demo-saucy-armhf-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webapps-demo-saucy-i386-ci/22

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webapps-demo-ci/39/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * No (although file-upload won't actually be available until landed in the web browser)

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?

 * No test plan, performed manual tests of basic functionality on all web apps.

If you changed the UI, was the change specified/approved by design?

 * No change

If you changed the packaging (debian), did you subscribe a core-dev to this MP?

 * No change

Reply

Unmerged revisions

36. By Michael Sheldon

Increment version number of all apps with new security policies

35. By Michael Sheldon

Add content_exchange policy to any apps with upload fields

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches