Merge lp://staging/~michael-sheldon/webapps-core/file-upload into lp://staging/webapps-core

Proposed by Michael Sheldon
Status: Merged
Merge reported by: David Barth
Merged at revision: not available
Proposed branch: lp://staging/~michael-sheldon/webapps-core/file-upload
Merge into: lp://staging/webapps-core
Diff against target: 77 lines (+9/-6)
6 files modified
webapp-facebook/manifest.json (+1/-1)
webapp-facebook/webapp-facebook.json (+2/-1)
webapp-gmail/manifest.json (+1/-1)
webapp-gmail/webapp-gmail.json (+2/-1)
webapp-twitter/manifest.json (+1/-1)
webapp-twitter/webapp-twitter.json (+2/-1)
To merge this branch: bzr merge lp://staging/~michael-sheldon/webapps-core/file-upload
Reviewer Review Type Date Requested Status
David Barth (community) Approve
Olivier Tilloy Approve
Review via email: mp+215312@code.staging.launchpad.net

Commit message

Add content_exchange permission to apps with upload functionality

Description of the change

Add content_exchange permission to apps with upload functionality (twitter, gmail and facebook) and bump version numbers.

To post a comment you must log in.
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * The webbrowser-app file-upload branch is required to test upload functionality: https://code.launchpad.net/~michael-sheldon/webbrowser-app/file-upload/+merge/212605

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/webapps) on device or emulator?

 * Yes (but just tests from the applications section)

If you changed the UI, was the change specified/approved by design?

 * No change

If you changed the packaging (debian), did you subscribe a core-dev to this MP?

 * No change (only to click packaging)

Revision history for this message
Olivier Tilloy (osomon) wrote :

LGTM.

review: Approve
Revision history for this message
David Barth (dbarth) wrote :

+1 and thank you for the branch

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: