Merge lp://staging/~michael-sheldon/ubuntu-keyboard/fix-1669440 into lp://staging/ubuntu-keyboard
Proposed by
Michael Sheldon
| Status: | Approved |
|---|---|
| Approved by: | Andrew Hayzen |
| Approved revision: | 549 |
| Proposed branch: | lp://staging/~michael-sheldon/ubuntu-keyboard/fix-1669440 |
| Merge into: | lp://staging/ubuntu-keyboard |
| Diff against target: |
10 lines (+1/-0) 1 file modified
qml/KeyboardContainer.qml (+1/-0) |
| To merge this branch: | bzr merge lp://staging/~michael-sheldon/ubuntu-keyboard/fix-1669440 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Andrew Hayzen (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Fix fallback to English when the selected plugin is no longer available
Description of the change
Fix fallback to English when the selected plugin is no longer available
To post a comment you must log in.
Unmerged revisions
- 549. By Michael Sheldon
-
Fix fallback to English when the selected plugin is no longer available
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM, this fixes the issue by falling back to English.
Only minor thing is that the other language still appears when you press'n'hold the keyboard selector thing, and you can click on it but nothing happens. I wonder if either it shouldn't be shown or an error message should appear? But this can be done in another branch as this branch fixes the issue of the keyboard becoming unusable.