ubuntu-download-manager

Merge lp://staging/~michael-sheldon/ubuntu-download-manager/fix-1628635 into lp://staging/ubuntu-download-manager

  1. fix-1628635
  2. Merge into trunk
Proposed by Michael Sheldon
Status: Merged
Approved by: Ken VanDine
Approved revision: 375
Merged at revision: 377
Proposed branch: lp://staging/~michael-sheldon/ubuntu-download-manager/fix-1628635
Merge into: lp://staging/ubuntu-download-manager
Diff against target: 301 lines (+103/-12)
3 files modified
src/common/priv/ubuntu/transfers/base_daemon.cpp (+2/-2)
src/downloads/client/ubuntu/download_manager/download_impl.cpp (+90/-0)
tests/downloads/daemon/test_daemon.cpp (+11/-10)
To merge this branch: bzr merge lp://staging/~michael-sheldon/ubuntu-download-manager/fix-1628635
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+307313@code.staging.launchpad.net

Commit message

Reorder dbus object and service registration to be compatible with Qt 5.6
Fix crash when client can't talk to dbus service

Description of the change

Reorder dbus object and service registration to be compatible with Qt 5.6
Fix crash when client can't talk to dbus service

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:375
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-download-manager-ci/20/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1692/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1692/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-download-manager-ci/20/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~michael-sheldon/ubuntu-download-manager/fix-1628635 updated
376. By Michael Sheldon

Add checks full invalid dbus interface in DownloadImpl

377. By Michael Sheldon

Check validity of dbus interface as well as whether or not it's null prior to usage

378. By Michael Sheldon

Reorder dbus object and service registration to be compatible with Qt 5.6

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches