Oxide

Merge lp://staging/~michael-sheldon/oxide/fix-1384357 into lp://staging/~osomon/oxide/non-ime-initiated-text-edit

  1. fix-1384357
  2. Merge into non-ime-initiated-text-edit
Proposed by Michael Sheldon
Status: Merged
Merged at revision: 1029
Proposed branch: lp://staging/~michael-sheldon/oxide/fix-1384357
Merge into: lp://staging/~osomon/oxide/non-ime-initiated-text-edit
Diff against target: 33 lines (+21/-0)
2 files modified
patches/series (+1/-0)
patches/update-selection-on-non-ime-text-change.patch (+20/-0)
To merge this branch: bzr merge lp://staging/~michael-sheldon/oxide/fix-1384357
Reviewer Review Type Date Requested Status
Olivier Tilloy Pending
Review via email: mp+259382@code.staging.launchpad.net

Commit message

Update the surrounding text reported to the keyboard when a text field is changed programmatically

Description of the change

Update the surrounding text reported to the keyboard when a text field is changed programmatically

To post a comment you must log in.
lp://staging/~michael-sheldon/oxide/fix-1384357 updated
1077. By Michael Sheldon

Merge from non-ime-initiated-text-edit and resolve conflicts

Revision history for this message
Olivier Tilloy (osomon) wrote :

This works well and fixes the original issue tracked by bug #1384357.

However I’m seeing a similar issue (that was mentioned in https://bugs.launchpad.net/oxide/+bug/1384357/comments/5): after clearing the text field with the X, swiping the app away from the right edge to reveal the app previews restores the preedit text.

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

I think we can go ahead and land this as it is, it looks like the fix for the other issue will either be in maliit-framework or ubuntu-keyboard (I have a working patch for maliit-framework already, but I'd like to see if it can be done in a less invasive way via ubuntu-keyboard first)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches