Merge lp://staging/~michael-sheldon/maliit/obey-unity8-focus into lp://staging/~ubuntu-core-dev/maliit/maliit-framework-ubuntu

What happens if another app gains focus after this check? Does maliit receive some sort of notification so that it can revalidate that the connected app still has focus?

When application focus is changed the OSK is dismissed, once a field that accepts input is focused in a new app after the switch it requests the active context again causing the focus to be checked for the new app prior to the keyboard being displayed again.

Thanks. That makes sense.

What happens if the application exits, gets killed, etc., after the isPidFocused check returns true? Does another application gain focus and get access to the OSK or is the OSK immediately dismissed?

activateContext only provides access to the keyboard for the dbus connection that requested it, so even if the keyboard wasn't dismissed (which it should be), no other application would gain access without first requesting that they be made the activate context (and so being subject to a focus check)

And dbus connections in maliit are peer-to-peer, so once the app dies its authorised dbus connection dies with it.

Hi Michael - I'm happy with the higher level design answers that you provided. I had one small observation in that I left inline. I'm going to go ahead and give this my approval but would like you to follow up on the observation. I'm assuming that you'll get someone more familiar with maliit/Mir to give a closer code review than I can provide but I've given the diff a cursory look.

Patch looks ok to me. Didn't test though.

Nitpicks:

"""
 DBusInputContextConnection::~DBusInputContextConnection()
 {
+ if (mUnityFocus != 0) {
+ delete mUnityFocus;
+ }
 }
"""

This check is unnecessary. You can simply call delete straightaway. It will be a NOOP if the pointer is null.

--------

"""
+++ maliit-framework-0.99.1+git20151118+62bd54b/connection/dbusinputcontextconnection.h
@@ -19,7 +19,9 @@

 #include "serverdbusaddress.h"

+#include <QDBusArgument>
 #include <QDBusContext>
+#include <QDBusInterface>
 #include <QDBusVariant>

"""

Since I don't that QDBusArgument header being used here, I would move that #include to the cpp file.

To further lighten up this header file, I would also move "#include <QDBusInterface>" to the cpp and have a "class QDBusInterface" forward declaration instead, which is enough for this header.