Merge lp://staging/~michael-sheldon/jokosher/recording-preferences-bitrates into lp://staging/jokosher
Proposed by
Michael Sheldon
| Status: | Merged |
|---|---|
| Merged at revision: | 1120 |
| Proposed branch: | lp://staging/~michael-sheldon/jokosher/recording-preferences-bitrates |
| Merge into: | lp://staging/jokosher |
| Diff against target: |
616 lines (+204/-80) 4 files modified
Jokosher/Globals.py (+2/-2) Jokosher/PreferencesDialog.py (+46/-4) Jokosher/Project.py (+9/-3) gtk-builder-ui/PreferencesDialog.ui (+147/-71) |
| To merge this branch: | bzr merge lp://staging/~michael-sheldon/jokosher/recording-preferences-bitrates |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Sheldon (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This branch allows for bit rates to be set for project wide recording when using a lossy recording method.
Without the changes included in this branch lossy formats are currently broken in trunk due ConfigParser attempting to interpret encoding strings containing "%(bitrate)d" parameters itself and failing. This branch switches to RawConfigParser (doesn't interpolate parameters like that) and provides relevant bitrate values when needed within Jokosher itself (along with making it possible for the user to set their preferred bitrate in the recording preferences).
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Merged.