gallery-app

Merge lp://staging/~michael-sheldon/gallery-app/add-content-hub-video-handler into lp://staging/gallery-app

  1. add-content-hub-video-handler
  2. Merge into trunk
Proposed by Michael Sheldon
Status: Merged
Approved by: Bill Filler
Approved revision: 1005
Merge reported by: Arthur Mello
Merged at revision: not available
Proposed branch: lp://staging/~michael-sheldon/gallery-app/add-content-hub-video-handler
Merge into: lp://staging/gallery-app
Diff against target: 60 lines (+28/-7)
2 files modified
click/gallery-content.json (+4/-2)
src/content-communicator.cpp (+24/-5)
To merge this branch: bzr merge lp://staging/~michael-sheldon/gallery-app/add-content-hub-video-handler
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+225311@code.staging.launchpad.net

Commit message

Add videos as supported content-hub destination and source type.

Description of the change

Add videos as supported content-hub destination and source type.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1005
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/883/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-utopic-amd64-ci/58
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-utopic-armhf-ci/58
        deb: http://jenkins.qa.ubuntu.com/job/gallery-app-utopic-armhf-ci/58/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-utopic-i386-ci/58
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-utopic-touch/134/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1262
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/283/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-utopic-armhf/192
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9156
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1039
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1410
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1410/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/883/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

approved

review: Approve
lp://staging/~michael-sheldon/gallery-app/add-content-hub-video-handler updated
1006. By Michael Sheldon

Place imported videos in ~/Videos

1007. By Michael Sheldon

If an incoming file doesn't have an extension add one based on the mimetype

1008. By Michael Sheldon

When creating new filename to avoid overwriting existing files on import, format filename so that original file extension is preserved

1009. By Michael Sheldon

Adjust placement of '.' in filenames without a suffix

1010. By Michael Sheldon

Merge from trunk

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/gallery-app) on device or emulator?

 * Yes

If you changed the UI, was the change specified/approved by design?

 * No change

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?

 * No change

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches