content-hub

Merge lp://staging/~michael-sheldon/content-hub/fix-1384490 into lp://staging/content-hub

  1. fix-1384490
  2. Merge into trunk
Proposed by Michael Sheldon
Status: Work in progress
Proposed branch: lp://staging/~michael-sheldon/content-hub/fix-1384490
Merge into: lp://staging/content-hub
Diff against target: 162 lines (+56/-6)
3 files modified
import/Ubuntu/Content/ContentPeerPicker.qdoc (+20/-0)
import/Ubuntu/Content/ContentPeerPicker10.qml (+18/-3)
import/Ubuntu/Content/ContentPeerPicker11.qml (+18/-3)
To merge this branch: bzr merge lp://staging/~michael-sheldon/content-hub/fix-1384490
Reviewer Review Type Date Requested Status
Ken VanDine Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+247144@code.staging.launchpad.net

Commit message

Allow for custom colouring of the ContentPeerPicker and default to theme colours otherwise

Description of the change

Allow for custom colouring of the ContentPeerPicker and default to theme colours otherwise

To post a comment you must log in.
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/content-hub) on device or emulator?

 * Yes

If you changed the UI, was the change specified/approved by design?

 * No change

If you changed UI labels, did you update the pot file?

 * No change

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?

 * No change

Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:179
http://jenkins.qa.ubuntu.com/job/content-hub-ci/214/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-vivid-amd64-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-vivid-armhf-ci/10
        deb: http://jenkins.qa.ubuntu.com/job/content-hub-vivid-armhf-ci/10/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-vivid-i386-ci/10

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/content-hub-ci/214/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Do you have any examples that we can use to test the new properties? And more importantly, to visually test the cases where we check the luminance?

review: Needs Information
Reply
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Here's a quick click package that provides a variety of cases for both light and dark backgrounds and panels: http://mikeasoft.com/~mike/content-hub/com.ubuntu.developer.michael-sheldon.test-picker-style_0.1_all.click

Reply
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?

 * Yes

Did CI run pass? If not, please explain why.

 * Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?

 * Yes

review: Approve
Reply

Unmerged revisions

179. By Michael Sheldon

Allow for custom colouring of the ContentPeerPicker and default to theme colours otherwise

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches