Unity

Merge lp://staging/~mhr3/unity/home-lens-ordering into lp://staging/unity

  1. home-lens-ordering
  2. Merge into trunk
Proposed by Michal Hruby
Status: Merged
Approved by: Paweł Stołowski
Approved revision: no longer in the source branch.
Merged at revision: 2649
Proposed branch: lp://staging/~mhr3/unity/home-lens-ordering
Merge into: lp://staging/unity
Prerequisite: lp://staging/~mhr3/unity/home-lens-fixes
Diff against target: 870 lines (+565/-20)
5 files modified
UnityCore/HomeLens.cpp (+268/-12)
UnityCore/HomeLens.h (+1/-0)
UnityCore/Lens.cpp (+35/-3)
UnityCore/Lens.h (+1/-0)
tests/test_home_lens.cpp (+260/-5)
To merge this branch: bzr merge lp://staging/~mhr3/unity/home-lens-ordering
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
Review via email: mp+122039@code.staging.launchpad.net

This proposal supersedes a proposal from 2012-08-30.

Commit message

Implement new ordering of categories for home lens

Description of the change

Implement new ordering of categories as requested by design (categories with the highest amount of personal content matches are on top, followed by categories without personal content [also sorted by number of matches]; plus apps are on top if they contain exact match or if they're binary name contains exact match).

To post a comment you must log in.
Revision history for this message
Paweł Stołowski (stolowski) wrote :

The code looks good, looking forward for a test as agreed on IRC.

Revision history for this message
Paweł Stołowski (stolowski) wrote :

Looks good, tests pass. Minor comments:

498 + std::string key_name(key);
Can we get rid of an extra string copy here? I think it would be ok to use glib string comparison.

224 + std::string lens_id(categories_merger_.GetLensIdForCategory(order_vector.at(i)));
Make it const.

review: Needs Fixing
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Cool!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.