unity-lens-shopping

Merge lp://staging/~mhr3/unity-lens-shopping/use-proper-emblems into lp://staging/unity-lens-shopping

  1. use-proper-emblems
  2. Merge into trunk
Proposed by Michal Hruby
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 24
Merged at revision: 24
Proposed branch: lp://staging/~mhr3/unity-lens-shopping/use-proper-emblems
Merge into: lp://staging/unity-lens-shopping
Diff against target: 64 lines (+36/-4)
2 files modified
src/scope.vala (+23/-4)
tests/manual-tests/shopping-lens-tests.txt (+13/-0)
To merge this branch: bzr merge lp://staging/~mhr3/unity-lens-shopping/use-proper-emblems
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Approve
Review via email: mp+126461@code.staging.launchpad.net

Commit message

Use proper emblems on the search results

Description of the change

So far we're not using proper emblems on the search results, this ensures we do.

Trivial change, no new tests.

To post a comment you must log in.
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Works fine with latest branch of Unity. +1.

review: Approve
Revision history for this message
Paweł Stołowski (stolowski) wrote :

Ahh.. can you update manual tests?

review: Needs Fixing
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity-lens-shopping/1/console reported an error when processing this lp:~mhr3/unity-lens-shopping/use-proper-emblems branch.
Not merging it.

Revision history for this message
Unity Merger (unity-merger) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Revision history for this message
Paweł Stołowski (stolowski) wrote :

+1

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity-lens-shopping/2/console reported an error when processing this lp:~mhr3/unity-lens-shopping/use-proper-emblems branch.
Not merging it.

Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity-lens-shopping/3/console reported an error when processing this lp:~mhr3/unity-lens-shopping/use-proper-emblems branch.
Not merging it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: