Merge lp://staging/~mhr3/unity-lens-music/no-results-hint into lp://staging/unity-lens-music

hey Michal,
please for this fix and simiar on other lenses, can you write an automated tests? (if I understand right now, the lens test infra is not there yet, so maybe at least a manual one?)
Thanks;

Didrocks, I understand your desire for automated tests (or at least a manual test), what should it really test? That it displays the hint when there are no results in the lens? And if it doesn't isn't it a rendering bug in unity(-2d)? Perhaps there are results for anything you type (after all there's the musicstore scope which might find anything) but they aren't properly propagated from scope to lens? Or perhaps there's a bug libunity and it doesn't pass the hint to unity?

You can imagine I could go on, but I guess my point of this being a crossroads of dozen different components makes it really difficult to test (and even more difficult to pinpoint origin of a possible failure - even with a manual test).

This is all backend side, so I guess an automatest when you make a search with "oihoihigiuguigigg", and ensure that you receive over dbus the "no-results-hint" is a first step.
I appreciate your different points, but I'm seeing more and more branches without any test going in, and telling "sure, but we can test x, y, z or w and we don't want just to pick one, so we do none of them" doesn't seem the way to go IMHO.

We have ½ of what we need to do proper tests for the lenses. That is dee-tool. We need to step up and write a unity-tool based on libunity that can instrument the lenses. But I don't think we need to block this merge on unity-tool.

Michal - if you add a TESTS-TODO.txt listing this I'll approve this branch. Then we'll make it a priority to write unity-tool and write the tests we've queued up thusly.