Merge lp://staging/~mhr3/unity-lens-files/moar-tests into lp://staging/unity-lens-files
Proposed by
Michal Hruby
| Status: | Merged |
|---|---|
| Approved by: | Mikkel Kamstrup Erlandsen |
| Approved revision: | 221 |
| Merged at revision: | 221 |
| Proposed branch: | lp://staging/~mhr3/unity-lens-files/moar-tests |
| Merge into: | lp://staging/unity-lens-files |
| Diff against target: |
211 lines (+164/-3) 6 files modified
Makefile.am (+1/-1) configure.ac (+1/-0) src/url-checker.vala (+2/-2) tests/Makefile.am (+27/-0) tests/assertions.vapi (+23/-0) tests/test-url-checker.vala (+110/-0) |
| To merge this branch: | bzr merge lp://staging/~mhr3/unity-lens-files/moar-tests |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mikkel Kamstrup Erlandsen (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Fix URL checking regressions, add tests
Description of the change
Fixes regressions in UrlChecker, adds unit tests for UrlChecker
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Loving it!
(have you considered upstreaming assertions.vapi? I think it would be great to have a GLib.Assertions namespace)