DockManager

Merge lp://staging/~mhr3/dockmanager/metadata-update into lp://staging/dockmanager

  1. metadata-update
  2. Merge into trunk
Proposed by Michal Hruby
Status: Merged
Merged at revision: 32
Proposed branch: lp://staging/~mhr3/dockmanager/metadata-update
Merge into: lp://staging/dockmanager
Diff against target: 497 lines (+260/-74)
16 files modified
configure.ac (+4/-5)
daemon/dockmanager-daemon.vala (+188/-15)
metadata/banshee_control.py.info (+5/-4)
metadata/deluge_badge.py.info (+5/-4)
metadata/emesene_control.py.info (+5/-4)
metadata/gajim_badge.py.info (+5/-4)
metadata/gtg_menus.py.info (+5/-4)
metadata/liferea_badge.py.info (+5/-4)
metadata/open_terminal_here.py.info (+5/-4)
metadata/pidgin_control.py.info (+5/-4)
metadata/rhythmbox_control.py.info (+5/-4)
metadata/tomboy_menus.py.info (+5/-4)
metadata/transmission_badge.py.info (+5/-4)
metadata/tsclient_menus.py.info (+5/-4)
metadata/zeitgeist_journal.py.info (+4/-3)
metadata/zeitgeist_menus.py.info (+4/-3)
To merge this branch: bzr merge lp://staging/~mhr3/dockmanager/metadata-update
Reviewer Review Type Date Requested Status
Robert Dyer (community) Needs Fixing
Review via email: mp+26745@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Robert Dyer (psybers) wrote :

First of all, your diff includes way more than what you wanted. You should fix that up.

Second, what is the point to the metadata changes? What is the format used? Is it just a true INI file format? Must we verify the section is named 'DEFAULT'? What if it isnt, do we still use it? Will we allow other sections, if so what are those?

review: Needs Fixing
Revision history for this message
Michal Hruby (mhr3) wrote :

It includes changes to the daemon which read this format, so it's related.

It's standard key-file format used everywhere (and parser for it available in glib), section name is required in keyfiles, therefore if it's not there, it's invalid. As for supporting more sections and/or keys it's easily possible when needed.

Revision history for this message
Robert Dyer (psybers) wrote :

Ok but the name of the section, is that a standard? Or are we going to just grab the first section in the file? What if there are more sections?

Revision history for this message
Michal Hruby (mhr3) wrote :

The APIs reading keyfiles usually need both group name and key name, so you shouldn't just grab the first one, anyway maybe we should use something more specific than "DEFAULT" (for example .desktop files use "DesktopEntry"), perhaps "DockmanagerHelper"?

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

The new metadata-file format is fine. "DockmanagerHelper" sounds good.

lp://staging/~mhr3/dockmanager/metadata-update updated
32. By Michal Hruby

Use DockmanagerHelper

Revision history for this message
Michal Hruby (mhr3) wrote :

Branch updated, please merge when Docky is ready to handle it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: