Animal Farm

Merge lp://staging/~mhall119/animal-farm/audio-fix into lp://staging/animal-farm

  1. audio-fix
  2. Merge into trunk
Proposed by Michael Hall
Status: Merged
Merged at revision: 29
Proposed branch: lp://staging/~mhall119/animal-farm/audio-fix
Merge into: lp://staging/animal-farm
Diff against target: 373 lines (+241/-22)
13 files modified
.bzrignore (+1/-0)
.excludes (+5/-0)
AnimalButton.qml (+1/-1)
Makefile (+22/-0)
animal-farm.apparmor (+5/-2)
animal-farm.desktop (+4/-4)
animal-farm.qmlproject (+34/-6)
main.qml (+1/-1)
manifest.json (+9/-8)
tests/autopilot/animal-farm/__init__.py (+72/-0)
tests/autopilot/animal-farm/test_main.py (+25/-0)
tests/autopilot/run (+12/-0)
tests/unit/tst_hellocomponent.qml (+50/-0)
To merge this branch: bzr merge lp://staging/~mhall119/animal-farm/audio-fix
Reviewer Review Type Date Requested Status
Robert Ancell Approve
Review via email: mp+235392@code.staging.launchpad.net

Description of the change

* Upgrade to latest SDK project format, so QtCreator treats it right

* Bump Ubuntu.Components version to 1.1, doesn't change anything just housekeeping

* Use newer click framework, 13.10 is so last year

* Add audio security group to allow sound playback

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Do we need to be in the networking policy group?

"Tests for the Hello World" - is this a copy-paste error?

Revision history for this message
Michael Hall (mhall119) wrote :

Networking is added to all new projects, I don't know if it's necessary to interact with other parts of the system or not, but it's considered a safe policy to give to any app and it does no harm.

The tests are boilerplate from a new project, since you didn't have any tests yet I just left them as they came as constant reminder that you haven't written any :)

Revision history for this message
Robert Ancell (robert-ancell) wrote :

OK, thanks Michael!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches