Merge lp://staging/~mh0/ubuntu-drupal-theme/6.x-2010 into lp://staging/ubuntu-drupal-theme
Proposed by
Micheal Harker
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~mh0/ubuntu-drupal-theme/6.x-2010 |
| Merge into: | lp://staging/ubuntu-drupal-theme |
| Diff against target: |
38 lines (+3/-4) 1 file modified
styles/base.css (+3/-4) |
| To merge this branch: | bzr merge lp://staging/~mh0/ubuntu-drupal-theme/6.x-2010 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Lustfield (community) | Needs Fixing | ||
|
Review via email:
|
|||
To post a comment you must log in.
Unmerged revisions
- 80. By Micheal Harker <michealh@michealh-laptop>
-
Fixed broken header
- 79. By Micheal Harker <michealh@michealh-laptop>
-
Trying something else
- 78. By Micheal Harker <michealh@michealh-laptop>
-
Fixed a silly mistake
- 77. By Micheal Harker <michealh@michealh-laptop>
-
Fixed issues
- 76. By Micheal Harker <michealh@michealh-laptop>
-
Fixed header using margin: -9px auto 0;
- 75. By Micheal Harker <michealh@michealh-laptop>
-
For my first merge proposal into lp:ubuntu-drupal-theme
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This merge would involve applying a static minimum width to an element that as a configurable minimum width available from the theme settings.
A min-width should not be used to fix this and should instead be used to decide where horizontal scrolling starts.
In addition, the min-width should not be decided on by the designer but rather by the person using the theme.