Code review comment for ~mertkirpici/juju-lint:lp/1987951
Revision history for this message
| Mert Kirpici (mertkirpici) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
be597b5
demo site
(Get the code!)
Rebased the branch and pushed an update to partially address Gabriel's comments.
A small summary of changes:
- I did get rid of the `--output-dir` flag rather than the `--dump-state` since it felt more intuitive for me to use it like "dump the state to DIR", rather than "output to DIR" which begs the question "What output?"
- Now we are checking the dump directory for permissions and existence before running any sort of linting.
- New functests for this feature.
I am thinking of filing bugs and addressing the issues #1(missing lint results in dumps) and #2(sensitive info in dumps) in separate MPs since they are quite serious bugs within themselves.
Last but not least, here is the functest run after this change:
https:/