Prometheus Openstack Exporter Charm

Merge ~mertkirpici/charm-prometheus-openstack-exporter:chore/drop-bionic into charm-prometheus-openstack-exporter:master

  1. Git
  2. lp:~mertkirpici/charm-prometheus-openstack-exporter
  3. chore/drop-bionic
  4. Merge into master
Proposed by Mert Kirpici
Status: Merged
Approved by: Andrea Ieri
Approved revision: d380ec1c616b40f0a0067cee73549731b7acea70
Merged at revision: 19d016f7c125d65a244e19ee80eb1cd7347937f7
Proposed branch: ~mertkirpici/charm-prometheus-openstack-exporter:chore/drop-bionic
Merge into: charm-prometheus-openstack-exporter:master
Diff against target: 98 lines (+9/-47)
4 files modified
charmcraft.yaml (+1/-9)
dev/null (+0/-35)
src/tests/functional/tests/bundles/overlays/local-charm-overlay.yaml.j2 (+6/-0)
src/tests/functional/tests/tests.yaml (+2/-3)
Reviewer Review Type Date Requested Status
🤖 prod-jenkaas-bootstack continuous-integration Needs Fixing
Andrea Ieri Approve
Tianqi Xiao (community) Approve
Review via email: mp+451886@code.staging.launchpad.net

Commit message

chore: drop bionic support

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

FAILED: Continuous integration, rev:eeaa92ccf8886a76e75362e71dbb871893a09cdc
https://jenkins.canonical.com/bootstack/job/lp-charm-prometheus-openstack-exporter-ci/15/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/bootstack/job/lp-charm-test-functest/1862/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/533/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-prometheus-openstack-exporter-ci/15//rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

PASSED: Continuous integration, rev:21563a870cc54c6a4be97c0ffdd49821d02ba5e4
https://jenkins.canonical.com/bootstack/job/lp-charm-prometheus-openstack-exporter-ci/16/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/bootstack/job/lp-charm-test-functest/1864/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/534/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-prometheus-openstack-exporter-ci/16//rebuild

review: Approve (continuous-integration)
Revision history for this message
Tianqi Xiao (txiao) wrote :

LGTM. I have one comment inline, but it is not blocking.

review: Approve
Revision history for this message
Andrea Ieri (aieri) :
review: Approve
Revision history for this message
Andrea Ieri (aieri) wrote :

on second thought, I agree with Tianqi's comment

review: Needs Fixing
Revision history for this message
Andrea Ieri (aieri) :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 19d016f7c125d65a244e19ee80eb1cd7347937f7

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

FAILED: Continuous integration, rev:d380ec1c616b40f0a0067cee73549731b7acea70
https://jenkins.canonical.com/bootstack/job/lp-charm-prometheus-openstack-exporter-ci/17/
Executed test runs:
    ABORTED: https://jenkins.canonical.com/bootstack/job/lp-charm-test-functest/1874/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/540/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-prometheus-openstack-exporter-ci/17//rebuild

review: Needs Fixing (continuous-integration)

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: