Merge lp://staging/~mefrio-g/pantheon-notify/fix-986822 into lp://staging/~tombeckmann/pantheon-notify/trunk
Proposed by
Mario Guerriero
| Status: | Needs review | ||||
|---|---|---|---|---|---|
| Proposed branch: | lp://staging/~mefrio-g/pantheon-notify/fix-986822 | ||||
| Merge into: | lp://staging/~tombeckmann/pantheon-notify/trunk | ||||
| Diff against target: |
13 lines (+1/-1) 1 file modified
src/notification.vala (+1/-1) |
||||
| To merge this branch: | bzr merge lp://staging/~mefrio-g/pantheon-notify/fix-986822 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Victor Martinez (community) | Needs Fixing | ||
| Tom Beckmann | Pending | ||
|
Review via email:
|
|||
To post a comment you must log in.
Unmerged revisions
- 18. By Mario Guerriero
-
fixed bug #986822
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
It would be better if you escaped the text before setting the markup. For instance:
name = Markup.escape (name, -1);
body = Markup.escape (body -1);
text.set_markup ("<span font='10' weight='bold'>" + name + "</span>\n<span font='9'>" + body + "</span>");