Merge lp://staging/~mcintire-evan/ubuntu-terminal-app/toggle_keyboard into lp://staging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

Proposed by Evan McIntire
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 144
Merged at revision: 147
Proposed branch: lp://staging/~mcintire-evan/ubuntu-terminal-app/toggle_keyboard
Merge into: lp://staging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target: 104 lines (+28/-12)
4 files modified
po/com.ubuntu.terminal.pot (+7/-3)
src/app/qml/SettingsPage.qml (+8/-0)
src/app/qml/TerminalPage.qml (+11/-9)
src/app/qml/TerminalSettings.qml (+2/-0)
To merge this branch: bzr merge lp://staging/~mcintire-evan/ubuntu-terminal-app/toggle_keyboard
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Review via email: mp+281005@code.staging.launchpad.net

Commit message

Added an option to toggle the visibility of the keyboard button.

Description of the change

Added an option to toggle the visibility of the keyboard button.

To post a comment you must log in.
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

This is great, thanks Evan!

review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches