Merge lp://staging/~mbruzek/charms/trusty/fail2ban/trunk into lp://staging/~lazypower/charms/trusty/fail2ban/trunk

Proposed by Matt Bruzek
Status: Merged
Merged at revision: 4
Proposed branch: lp://staging/~mbruzek/charms/trusty/fail2ban/trunk
Merge into: lp://staging/~lazypower/charms/trusty/fail2ban/trunk
Diff against target: 511 lines (+111/-299)
8 files modified
Makefile (+7/-20)
README.md (+24/-17)
config.yaml (+1/-1)
lib/charmhelpers/fetch/__init__.py (+1/-1)
metadata.yaml (+2/-2)
scripts/charm_helpers_sync.py (+0/-223)
tests/00-setup (+2/-2)
tests/10-deploy (+74/-33)
To merge this branch: bzr merge lp://staging/~mbruzek/charms/trusty/fail2ban/trunk
Reviewer Review Type Date Requested Status
Charles Butler Approve
Review via email: mp+242506@code.staging.launchpad.net

Description of the change

I removed some things from the Makefile, wrote proper tests and updated the README.

To post a comment you must log in.
Revision history for this message
Charles Butler (lazypower) wrote :

Thanks for the cleanup Matt! These additions look good to me.

review: Approve
4. By Charles Butler

   [r=lazypower]Matt Bruzek 2014-11-21 Updates to Makefile, README.md, config, and metadata, and now with better ...
    Matt Bruzek 2014-11-20 Removing redundant sync file and tests.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: