Ubuntu Distributed Development

Merge lp://staging/~mbp/udd/819910-service-root into lp://staging/udd

  1. 819910-service-root
  2. Merge into import-scripts
Proposed by Martin Pool
Status: Merged
Approved by: John A Meinel
Approved revision: 505
Merged at revision: 505
Proposed branch: lp://staging/~mbp/udd/819910-service-root
Merge into: lp://staging/udd
Diff against target: 19 lines (+4/-4)
1 file modified
import_package.py (+4/-4)
To merge this branch: bzr merge lp://staging/~mbp/udd/819910-service-root
Reviewer Review Type Date Requested Status
John A Meinel Approve
Review via email: mp+71832@code.staging.launchpad.net

Description of the change

Use the root url expected by the Launchpad session object, to avoid httperrors.

I haven't yet put this through a whole run, but it does let me manually run the code from inside file_mp etc.

To post a comment you must log in.
Revision history for this message
Robert Collins (lifeless) wrote :

very similar to code I put into hydrazine. Looks fine to me.

lp://staging/~mbp/udd/819910-service-root updated
505. By Martin Pool

Use lp's branches.getByUrl rather than url hacking (thanks jam)

Revision history for this message
John A Meinel (jameinel) wrote :

I don't think this applies anymore:
# Strip off the scheme, and hostname.

And the syntax is ugly (having to lp_call(lp.branches.getByUrl the lp api seems a bit redundant)

However, it all looks correct and better than before.

review: Approve
lp://staging/~mbp/udd/819910-service-root updated
506. By Martin Pool

Remove dead comment

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches