testresources

Merge lp://staging/~mbp/testresources/doc into lp://staging/~testresources-developers/testresources/trunk

  1. doc
  2. Merge into trunk
Proposed by Martin Pool
Status: Merged
Merged at revision: 62
Proposed branch: lp://staging/~mbp/testresources/doc
Merge into: lp://staging/~testresources-developers/testresources/trunk
Diff against target: 101 lines (+21/-14)
1 file modified
README (+21/-14)
To merge this branch: bzr merge lp://staging/~mbp/testresources/doc
Reviewer Review Type Date Requested Status
Robert Collins Approve
Review via email: mp+130895@code.staging.launchpad.net

Description of the change

Hi,

I was using testresources and noticed a few unclear things in the readme - this fixes them.

Also, I was wondering how you would feel about a separate patch to add some specific managers, starting with the tempdir one.

thanks,
-m

To post a comment you must log in.
Revision history for this message
Robert Collins (lifeless) wrote :

Thanks for this, I shall look at it locally to see what the whitespace changes are and merge it.

I'd be happy to have specific managers that depend only on the standard library in testresources. For tempdir though, FixtureResource(fixtures.TempDir) should be all you need. Many things are probably best expressed as fixtures, not as resources + resource managers, and used via FixtureResource.

review: Approve
Revision history for this message
Martin Pool (mbp) wrote :

Maybe the testresources readme should mention fixtures too?

Revision history for this message
Martin Pool (mbp) wrote :

On 23 October 2012 07:44, Robert Collins <email address hidden> wrote:

> Review: Approve
>
> Thanks for this, I shall look at it locally to see what the whitespace
> changes are and merge it.
>
> I'd be happy to have specific managers that depend only on the standard
> library in testresources. For tempdir though,
> FixtureResource(fixtures.TempDir) should be all you need. Many things are
> probably best expressed as fixtures, not as resources + resource managers,
> and used via FixtureResource.
>
>
Could I persuade you to make a release with FixtureResource some time?

--
Martin

Revision history for this message
Robert Collins (lifeless) wrote :

On Thu, Oct 25, 2012 at 10:28 AM, Martin Pool <email address hidden> wrote:
> Maybe the testresources readme should mention fixtures too?

It should :)

Revision history for this message
Robert Collins (lifeless) wrote :

On Thu, Oct 25, 2012 at 10:43 AM, Martin Pool <email address hidden> wrote:

> Could I persuade you to make a release with FixtureResource some time?

Here's one I prepared earlier http://pypi.python.org/pypi/testresources :)

-Rob

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches