Merge lp://staging/~mbp/loggerhead/240580-tarball into lp://staging/loggerhead
Proposed by
Martin Pool
| Status: | Merged |
|---|---|
| Approved by: | Robert Collins |
| Approved revision: | 475 |
| Merged at revision: | 461 |
| Proposed branch: | lp://staging/~mbp/loggerhead/240580-tarball |
| Merge into: | lp://staging/loggerhead |
| Prerequisite: | lp://staging/~xaav/loggerhead/export-tarball |
| Diff against target: |
498 lines (+209/-65) 12 files modified
info.py (+3/-2) loggerhead/__init__.py (+1/-1) loggerhead/apps/branch.py (+9/-10) loggerhead/controllers/download_ui.py (+20/-13) loggerhead/exporter.py (+18/-4) loggerhead/history.py (+0/-1) loggerhead/templates/branchinfo.pt (+2/-1) loggerhead/templates/menu.pt (+0/-4) loggerhead/templates/revision.pt (+2/-2) loggerhead/tests/fixtures.py (+43/-0) loggerhead/tests/test_controllers.py (+96/-14) loggerhead/tests/test_simple.py (+15/-13) |
| To merge this branch: | bzr merge lp://staging/~mbp/loggerhead/240580-tarball |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Robert Collins | Approve | ||
|
Review via email:
|
|||
Description of the change
This fixes up a few more things with a view to finally landing the export-tarball feature.
- incidentally cleans up test code
- tarballs are tgz by default
- add tests for this
- tarballs include the revspec (typically revno) in the name
To post a comment you must log in.
Revision history for this message
| Martin Pool (mbp) wrote | # |
Revision history for this message
| Robert Collins (lifeless) wrote | # |
Revision history for this message
| Robert Collins (lifeless) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
i tested the scalability and memory usage of this with an 800MB ulimit, running locally, downloading a tarball of the lp tree, which ends up being 68MB. At 500MB it runs out of memory extracting the text.