lazr.restfulclient

Merge lp://staging/~mbp/lazr.restfulclient/789369-getattr into lp://staging/lazr.restfulclient

  1. 789369-getattr
  2. Merge into trunk
Proposed by Martin Pool
Status: Merged
Merged at revision: 115
Proposed branch: lp://staging/~mbp/lazr.restfulclient/789369-getattr
Merge into: lp://staging/lazr.restfulclient
Diff against target: 14 lines (+2/-2)
1 file modified
src/lazr/restfulclient/resource.py (+2/-2)
To merge this branch: bzr merge lp://staging/~mbp/lazr.restfulclient/789369-getattr
Reviewer Review Type Date Requested Status
Robert Collins (community) Approve
Benji York Pending
Review via email: mp+62743@code.staging.launchpad.net

Commit message

better AttributeError messages

Description of the change

This makes lazr.restful give you an error like so:

AttributeError: 'https://api.launchpad.net/1.0/~chrisjohnston/launchpad/483373' object has no attribute 'queue_status'

which personally I think is much more useful.

To post a comment you must log in.
Revision history for this message
Robert Collins (lifeless) wrote :

Looks fine

review: Approve
Revision history for this message
Martin Pool (mbp) wrote :

How can this get landed? Robert suggested an approved mp with a commit message would be pulled by Tarmac, but apparently not...

Revision history for this message
Martin Pool (mbp) wrote :

Hi Benji, could you please review and/or land this?

Revision history for this message
Francis J. Lacoste (flacoste) wrote :

Martin, you can land this yourself. Gated merge was never set-up for most lazr projects (apart lazr-js). You simply checkout lp:lazr.restful, merge your branch in and commit.

Revision history for this message
Martin Pool (mbp) wrote :

thanks, done.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches