Launchpad itself

Merge lp://staging/~mbp/launchpad/925597-dkim-from into lp://staging/launchpad

  1. 925597-dkim-from
  2. Merge into devel
Proposed by Martin Pool
Status: Merged
Approved by: Martin Pool
Approved revision: no longer in the source branch.
Merged at revision: 15093
Proposed branch: lp://staging/~mbp/launchpad/925597-dkim-from
Merge into: lp://staging/launchpad
Diff against target: 430 lines (+195/-67)
2 files modified
lib/lp/services/mail/incoming.py (+55/-18)
lib/lp/services/mail/tests/test_dkim.py (+140/-49)
To merge this branch: bzr merge lp://staging/~mbp/launchpad/925597-dkim-from
Reviewer Review Type Date Requested Status
Ian Booth (community) Approve
Brad Crittenden (community) code Approve
Review via email: mp+98976@code.staging.launchpad.net

Commit message

cope with mail dkim-signed by addresses that aren't know to launchpad

Description of the change

This fixes bug <https://bugs.launchpad.net/launchpad/+bug/925597> which is hit if you are sending mail from gmail, but your gmail address is not registered with lp.

I wonder if I also need to test the case that your gmail address is known but not verified? I probably should.

To post a comment you must log in.
Revision history for this message
Brad Crittenden (bac) wrote :

Thanks for the fix Martin. Your changes are clear and the new test case is quite readable.

'make lint' shows a couple of valid items along with the usual suspects of non-issues. If you have a second to address those it would be nice.

Again, thanks for this fix and for championing the DKIM support.

review: Approve (code)
Revision history for this message
Martin Pool (mbp) wrote :

Thanks for the prompt friendly review!

I think it will be worth adding the other test case, so I'll try to do that
today or tomorrow, then get an incremental review and merge it myself.

Revision history for this message
Martin Pool (mbp) wrote :

I cleaned it up a bit more, and added a test for mail signed by unverified addresses, which was a case that needed to be handled.

Revision history for this message
Ian Booth (wallyworld) wrote :

Looks great. Thanks for making the changes suggested on irc.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.