Merge lp://staging/~mbp/launchpad/855150-mail-disabled into lp://staging/launchpad
Proposed by
Martin Pool
| Status: | Merged |
|---|---|
| Approved by: | Curtis Hovey |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 14050 |
| Proposed branch: | lp://staging/~mbp/launchpad/855150-mail-disabled |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
92 lines (+43/-6) 2 files modified
lib/lp/registry/model/person.py (+10/-6) lib/lp/registry/tests/test_person.py (+33/-0) |
| To merge this branch: | bzr merge lp://staging/~mbp/launchpad/855150-mail-disabled |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Curtis Hovey (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
[r=sinzui] [bug=858605] don't send mail to individuals without an active account
Description of the change
This handles bug 858605 (split from bug 855150), which is that Launchpad sends mail to people who have deactivated accounts. I addressed this by changing get_recipients to check against the account table too, and adding a unit test for this. I also checked the uses of get_recipients and none seems like it would actually want to be mailing deactivated accounts - perhaps the only case for that would be if people wanted to reactivate them, and I think they have to log in first.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
W00t! Thank you very much.