Launchpad itself

Merge lp://staging/~mbp/launchpad/808282-canonical-url into lp://staging/launchpad

808282-canonical-url
Merge into devel

Proposed by Martin Pool on 2011-11-20

Status:

Merged

Approved by:

Martin Pool on 2011-11-22

Approved revision:

no longer in the source branch.

Merged at revision:

14382

Proposed branch:

lp://staging/~mbp/launchpad/808282-canonical-url

Merge into:

lp://staging/launchpad

Diff against target:

127 lines (+61/-4)

4 files modified

lib/canonical/launchpad/webapp/publisher.py (+24/-1)
lib/lp/app/templates/base-layout.pt (+7/-3)
lib/lp/bugs/browser/bugtask.py (+4/-0)
lib/lp/bugs/browser/tests/test_bug_views.py (+26/-0)

To merge this branch:

bzr merge lp://staging/~mbp/launchpad/808282-canonical-url

Low

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Paul Sladen (community)			Approve on 2011-11-23
Benji York (community)	code	2011-11-20	Approve on 2011-11-21
Review via email: mp+82811@code.staging.launchpad.net

Commit message

[r=benji,sladen] [r=benji][bug=808282] add recommended_canonical_url, feeding <link rel=canonical>

Description of the change

Per discussion in bug 808282, it's possible Launchpad can help search engines give better results by sending <link rel=canonical> on bug pages. This adds a general mechanism for doing this and does it on bug pages.

Revision history for this message

Benji York (benji) wrote on 2011-11-21:

This looks good.

I would have been tempted to call the method canonical_canonical_url.

The comment in the test doesn't quite parse though:

# Hardcode this to avoid be sure we've really got what we expected.

Removing the word "avoid" sheems appropriate.

review: Approve (code)

Revision history for this message

Martin Pool (mbp) wrote on 2011-11-22:

On 22 November 2011 01:55, Benji York <email address hidden> wrote:
> Review: Approve code
>
> This looks good.
>
> I would have been tempted to call the method canonical_canonical_url.

Are you serious? Or did you mean recommended_canonical_url, which
could be good.

>
> The comment in the test doesn't quite parse though:
>
> # Hardcode this to avoid be sure we've really got what we expected.
>
> Removing the word "avoid" sheems appropriate.

shure doesh

--
Martin

Revision history for this message

Paul Sladen (sladen) wrote on 2011-11-23:

Looks excellent.

What's the thinking these days between promoting the following?:

a. bugs.launchpad.net/…
b. launchpad.net/bugs/…

(the first is sent out in emails, but the latter is shorter and avoids the duplication). Looking at the returned 'Location:' headers, both entry points return http://bugs.launchpad.net/context/… in a single step.

review: Approve

Revision history for this message

Martin Pool (mbp) wrote on 2011-11-23:

On 23 November 2011 11:04, Paul Sladen <email address hidden> wrote:
> Review: Approve
>
> Looks excellent.
>
> What's the thinking these days between promoting the following?:
>
> a. bugs.launchpad.net/…
> b. launchpad.net/bugs/…

I believe the plan is to eventually reunify everything on to a single
domain. There has been some launchpad-dev discussion. It is not a
top priority though.

--
Martin